src: make `FIXED_ONE_BYTE_STRING` an inline fn by addaleax · Pull Request #22725

src: make `FIXED_ONE_BYTE_STRING` an inline fn by addaleax · Pull Request #22725 · nodejs/node

This prevents accidental usage on non-fixed strings.

added c++

Issues and PRs that require attention from people who are familiar with C++.

node-api

Issues and PRs related to the Node-API.

labels

Sep 6, 2018

addaleax added lib / src

Issues and PRs related to general changes in the lib or src directory.

and removed node-api

Issues and PRs related to the Node-API.

labels

Sep 6, 2018

addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 9, 2018

danbev pushed a commit that referenced this pull request

Sep 10, 2018

This prevents accidental usage on non-fixed strings.

PR-URL: #22725
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Sep 10, 2018

This prevents accidental usage on non-fixed strings.

PR-URL: #22725
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>