Home Original page

src: remove trace_sync_io_ from env by danbev · Pull Request #22726 · nodejs/node

@danbev 

This commit removes trace_sync_io_ and instead uses the options value
directly.

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Sep 6, 2018

addaleax

mihalskiy

Fishrock123

@danbev danbev deleted the remove_trace_sync_io_ branch

September 9, 2018 12:47

danbev added a commit that referenced this pull request

Sep 9, 2018 
This commit removes trace_sync_io_ and instead uses the options value
directly.

PR-URL: #22726
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

targos pushed a commit that referenced this pull request

Sep 10, 2018 
This commit removes trace_sync_io_ and instead uses the options value
directly.

PR-URL: #22726
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This was referenced

Aug 1, 2019

ChALkeR added a commit to ChALkeR/io.js that referenced this pull request

Aug 2, 2019

Trott pushed a commit to Trott/io.js that referenced this pull request

Aug 4, 2019 
This reverts commit 7fa5f54.

The reverted commit breaks the logic behind --trace-sync-io, it should
be enabled only at a certain point in time, while that commit enables
it from the very start, causing warnings be printed for all sync io
instead of sync io after the first tick of the event loop as documented.

Fixes: nodejs#28913
Refs: nodejs#22726
Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io
PR-URL: nodejs#28926
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Aug 6, 2019 
This reverts commit 7fa5f54.

The reverted commit breaks the logic behind --trace-sync-io, it should
be enabled only at a certain point in time, while that commit enables
it from the very start, causing warnings be printed for all sync io
instead of sync io after the first tick of the event loop as documented.

Fixes: #28913
Refs: #22726
Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io
PR-URL: #28926
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>