Home Original page

crypto: fix public key encryption internals by tniessen · Pull Request #22780 · nodejs/node

@tniessen 

Coincidentally, the old version works as well since the padding parameter is never null, but it is semantically incorrect.

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

labels

Sep 9, 2018

BridgeAR

addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 12, 2018

@tniessen tniessen removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 12, 2018

tniessen added a commit that referenced this pull request

Sep 12, 2018 
Coincidentally, the old version works as well since the padding
parameter is never null, but it is semantically incorrect.

PR-URL: #22780
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Sep 14, 2018 
Coincidentally, the old version works as well since the padding
parameter is never null, but it is semantically incorrect.

PR-URL: #22780
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Sep 19, 2018 
Coincidentally, the old version works as well since the padding
parameter is never null, but it is semantically incorrect.

PR-URL: #22780
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Sep 20, 2018 
Coincidentally, the old version works as well since the padding
parameter is never null, but it is semantically incorrect.

PR-URL: #22780
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>