lib: remove useless input parameters and make 'digest' clear in the doc · Pull Request #22858 · nodejs/node
ghost
changed the title
lib: Fix and Remove useless input parameters
lib: Remove useless input parameters
ghost
changed the title
lib: Remove useless input parameters
lib: Remove useless input parameters and make 'digest' clear in the doc
ghost
changed the title
lib: Remove useless input parameters and make 'digest' clear in the doc
lib: remove useless input parameters and make 'digest' clear in the doc
1) Remove 'callback' in 'check' function, because we don't check or use that directly. 2) Adjust the orders of codes in 'pbkdf2' to have a quick check whether the callback is a function or not instead of using it into the 'check' method. 3) Make 'digest' more clear in doc.
tniessen pushed a commit that referenced this pull request
Sep 18, 20181) Remove 'callback' in 'check' function, because we don't check or use that directly. 2) Make 'digest' clearer in the documentation. PR-URL: #22858 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ghost
deleted the
FixAndRemove
branch
targos pushed a commit that referenced this pull request
Sep 19, 20181) Remove 'callback' in 'check' function, because we don't check or use that directly. 2) Make 'digest' clearer in the documentation. PR-URL: #22858 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request
Sep 20, 20181) Remove 'callback' in 'check' function, because we don't check or use that directly. 2) Make 'digest' clearer in the documentation. PR-URL: #22858 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters