lib: remove useless input parameters and make 'digest' clear in the doc · Pull Request #22858 · nodejs/node

@nodejs-github-bot added the crypto

Issues and PRs related to the crypto subsystem.

label

Sep 14, 2018

@ghost ghost changed the title lib: Fix and Remove useless input parameters lib: Remove useless input parameters

Sep 14, 2018

@ghost ghost changed the title lib: Remove useless input parameters lib: Remove useless input parameters and make 'digest' clear in the doc

Sep 14, 2018

mscdex

mscdex

mscdex

@ghost ghost changed the title lib: Remove useless input parameters and make 'digest' clear in the doc lib: remove useless input parameters and make 'digest' clear in the doc

Sep 14, 2018

mscdex

mscdex

mscdex

Trott

Trott

tniessen

tniessen

1) Remove 'callback' in 'check' function, because we don't check or use
that directly.

2) Adjust the orders of codes in 'pbkdf2' to have a quick check whether
the callback is a function or not instead of using it into the 'check'
method.

3) Make 'digest' more clear in doc.

tniessen

tniessen pushed a commit that referenced this pull request

Sep 18, 2018
1) Remove 'callback' in 'check' function, because we don't check or use
that directly.

2) Make 'digest' clearer in the documentation.

PR-URL: #22858
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@ghost ghost deleted the FixAndRemove branch

September 19, 2018 02:24

targos pushed a commit that referenced this pull request

Sep 19, 2018
1) Remove 'callback' in 'check' function, because we don't check or use
that directly.

2) Make 'digest' clearer in the documentation.

PR-URL: #22858
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Sep 20, 2018
1) Remove 'callback' in 'check' function, because we don't check or use
that directly.

2) Make 'digest' clearer in the documentation.

PR-URL: #22858
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>