Home Original page

tools: synchronize deepStrictEqual() message rules by Trott · Pull Request #22887 · nodejs/node

@Trott 

Update ESLint config to include a rule about assert.deepStrictEqual()
messages and string literals. The rule is included in lib and test, but
should be included everywhere else as well.

@nodejs-github-bot added the tools

Issues and PRs related to the tools directory.

label

Sep 17, 2018

@Trott Trott added the fast-track

PRs that do not need to wait for 72 hours to land.

label

Sep 18, 2018

thefourtheye

not-an-aardvark

richardlau

Trott added a commit to Trott/io.js that referenced this pull request

Sep 18, 2018 
Update ESLint config to include a rule about assert.deepStrictEqual()
messages and string literals. The rule is included in lib and test, but
should be included everywhere else as well.

PR-URL: nodejs#22887
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

targos pushed a commit that referenced this pull request

Sep 19, 2018 
Update ESLint config to include a rule about assert.deepStrictEqual()
messages and string literals. The rule is included in lib and test, but
should be included everywhere else as well.

PR-URL: #22887
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

targos pushed a commit that referenced this pull request

Sep 20, 2018 
Update ESLint config to include a rule about assert.deepStrictEqual()
messages and string literals. The rule is included in lib and test, but
should be included everywhere else as well.

PR-URL: #22887
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@Trott Trott deleted the whoop-deepstrictequal branch

January 13, 2022 22:50