Home Original page

test: Remove string literals for strictEquals/notStrictEquals · Pull Request #22891 · nodejs/node

Ref: #22849.

In short: Some unit tests are using string literals to simply tell you a
conclusion what's right/wrong BUT not tell you what actually values are.
So it's necessary to print them out in the console.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Sep 17, 2018

Trott

thefourtheye

lundibundi

addaleax pushed a commit that referenced this pull request

Sep 22, 2018 
In short: Some unit tests are using string literals to simply tell you a
conclusion what's right/wrong BUT not tell you what actually values are.
So it's necessary to print them out in the console.

Refs: #22849
PR-URL: #22891
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@ghost ghost deleted the RemovingStringLiteralErrors branch

September 23, 2018 00:48

targos pushed a commit that referenced this pull request

Sep 23, 2018 
In short: Some unit tests are using string literals to simply tell you a
conclusion what's right/wrong BUT not tell you what actually values are.
So it's necessary to print them out in the console.

Refs: #22849
PR-URL: #22891
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Oct 10, 2018