Home Original page

test: remove common.hasSmallICU by Trott · Pull Request #22937 · nodejs/node

@Trott 

common.hasSmallICU is used in only one test and is a one-liner. Move
into the test where it is used to chip away at the `common` monolith.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Sep 18, 2018

richardlau

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 18, 2018

tniessen

BridgeAR

refack

thefourtheye

Trott added a commit to Trott/io.js that referenced this pull request

Sep 20, 2018 
common.hasSmallICU is used in only one test and is a one-liner. Move
into the test where it is used to chip away at the `common` monolith.

PR-URL: nodejs#22937
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Sep 21, 2018 
common.hasSmallICU is used in only one test and is a one-liner. Move
into the test where it is used to chip away at the `common` monolith.

PR-URL: #22937
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This was referenced

Oct 10, 2018

@Trott Trott deleted the rm-hasSmallICU branch

January 13, 2022 22:50