Home Original page

test: increase coverage for worker_threads by Trott · Pull Request #22942 · nodejs/node

@Trott added test

Issues and PRs related to the tests.

worker

Issues and PRs related to Worker support.

labels

Sep 19, 2018

thefourtheye

@Trott 

Provide a test to cover adding setting `onmessage` to a non-function.

This provides previously-missing coverage for an else block in the
`onmessage` setter.

addaleax

thefourtheye

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 19, 2018

Trott added a commit to Trott/io.js that referenced this pull request

Sep 21, 2018 
Provide a test to cover adding setting `onmessage` to a non-function.

This provides previously-missing coverage for an else block in the
`onmessage` setter.

PR-URL: nodejs#22942
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>

targos pushed a commit that referenced this pull request

Sep 23, 2018 
Provide a test to cover adding setting `onmessage` to a non-function.

This provides previously-missing coverage for an else block in the
`onmessage` setter.

PR-URL: #22942
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>

This was referenced

Oct 10, 2018

This was referenced

Oct 11, 2018

@Trott Trott deleted the worker-coverage branch

January 13, 2022 22:50