test: fix flaky key pair generation test by tniessen · Pull Request #22980

test: fix flaky key pair generation test by tniessen · Pull Request #22980 · nodejs/node

added the test

Issues and PRs related to the tests.

label

Sep 20, 2018

addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 20, 2018

tniessen added a commit that referenced this pull request

Sep 20, 2018

There is a very small chance (about 0.4%) that OpenSSL will
successfully decrypt a key without the correct passphrase and will
then fail while parsing its ASN.1 structure. In those rare cases,
the error message will be different.

PR-URL: #22980
Fixes: #22978
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request

Sep 21, 2018

There is a very small chance (about 0.4%) that OpenSSL will
successfully decrypt a key without the correct passphrase and will
then fail while parsing its ASN.1 structure. In those rare cases,
the error message will be different.

PR-URL: #22980
Fixes: #22978
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

This was referenced

Oct 10, 2018

tniessen removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 14, 2021