Home Original page

build,deps: refactor and fix v8.gyp by refack · Pull Request #23182 · nodejs/node

@refack 

* Make inspector.gypi and v8_external_snapshot.gypi includible targets.
* Make `v8_dump_build_config` an action
* Better separate `js2c` and `natives_blob`
* process action outputs as sources
* trigger v8.gyp:postmortem-metadata from v8.gyp

@refack refack added the post-mortem

Issues and PRs related to the post-mortem diagnostics of Node.js.

label

Sep 30, 2018

targos pushed a commit to targos/node that referenced this pull request

Oct 4, 2018 
* Make inspector.gypi and v8_external_snapshot.gypi includible targets.
* Make `v8_dump_build_config` an action
* Better separate `js2c` and `natives_blob`
* process action outputs as sources
* trigger v8.gyp:postmortem-metadata from v8.gyp

PR-URL: nodejs#23182
Refs: nodejs#23156
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@refack refack deleted the v8-gyp-cleanup branch

October 4, 2018 14:11

targos pushed a commit that referenced this pull request

Oct 5, 2018 
* Make inspector.gypi and v8_external_snapshot.gypi includible targets.
* Make `v8_dump_build_config` an action
* Better separate `js2c` and `natives_blob`
* process action outputs as sources
* trigger v8.gyp:postmortem-metadata from v8.gyp

PR-URL: #23182
Refs: #23156
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

This was referenced

Oct 10, 2018

@refack refack restored the v8-gyp-cleanup branch

October 12, 2018 00:09

@refack refack deleted the v8-gyp-cleanup branch

October 12, 2018 00:16

jasnell pushed a commit that referenced this pull request

Oct 17, 2018 
* Make inspector.gypi and v8_external_snapshot.gypi includible targets.
* Make `v8_dump_build_config` an action
* Better separate `js2c` and `natives_blob`
* process action outputs as sources
* trigger v8.gyp:postmortem-metadata from v8.gyp

PR-URL: #23182
Refs: #23156
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

This was referenced

Oct 21, 2018