Home Original page

net: use connect() instead of connect.call() by JacksonTian · Pull Request #23289 · nodejs/node

@JacksonTian 

Use socket.connect() directly.

@nodejs-github-bot added the net

Issues and PRs related to the net subsystem.

label

Oct 6, 2018

thefourtheye

danbev pushed a commit that referenced this pull request

Oct 10, 2018 
Use socket.connect() directly.

PR-URL: #23289
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Thomas Watson <w@tson.dk>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Oct 10, 2018 
Use socket.connect() directly.

PR-URL: #23289
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Thomas Watson <w@tson.dk>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Oct 10, 2018

jasnell pushed a commit that referenced this pull request

Oct 17, 2018 
Use socket.connect() directly.

PR-URL: #23289
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Thomas Watson <w@tson.dk>
Reviewed-By: James M Snell <jasnell@gmail.com>