Home Original page

build: restore js2c direct dependency on config.gypi by refack · Pull Request #23355 · nodejs/node

@nodejs-github-bot added the build

Issues and PRs related to build files or the CI.

label

Oct 9, 2018

addaleax

joyeecheung

richardlau

@refack 

PR-URL: nodejs#23355
Fixes: nodejs#23352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@refack refack deleted the fix-js2c-config.gypi-dependenacy branch

October 10, 2018 14:47

targos pushed a commit that referenced this pull request

Oct 10, 2018 
PR-URL: #23355
Fixes: #23352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

This was referenced

Oct 10, 2018

This was referenced

Oct 11, 2018

jasnell pushed a commit that referenced this pull request

Oct 17, 2018 
PR-URL: #23355
Fixes: #23352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>