Home Original page

repl: handle buffered string logic on finish by antsmartian · Pull Request #24389 · nodejs/node

@nodejs-github-bot added readline

Issues and PRs related to the built-in readline module.

repl

Issues and PRs related to the REPL subsystem.

labels

Nov 16, 2018

jdalton

@antsmartian

Fishrock123

@vsemozhetbyt vsemozhetbyt added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 19, 2018

Fishrock123 pushed a commit that referenced this pull request

Nov 19, 2018 
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: #24389
Fixes: #24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Fishrock123 pushed a commit that referenced this pull request

Nov 19, 2018 
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: #24389
Fixes: #24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

targos pushed a commit that referenced this pull request

Nov 19, 2018 
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: #24389
Fixes: #24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

rvagg pushed a commit that referenced this pull request

Nov 28, 2018 
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: #24389
Fixes: #24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This was referenced

Dec 7, 2018

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019 
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: nodejs#24389
Fixes: nodejs#24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>