Home Original page

https: add missing localPort while create socket by leeight · Pull Request #24554 · nodejs/node

@nodejs-github-bot added the tls

Issues and PRs related to the tls subsystem.

label

Nov 21, 2018

mscdex

lpinca

@leeight 

In `_tls_wrap.js` while calling `socket.connect` the `localPort` was
missing, restore it.

Fix: nodejs#24543

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 21, 2019

BridgeAR

@lpinca lpinca added the https

Issues or PRs related to the https subsystem.

label

Mar 1, 2019

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 5, 2019 
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was
missing, restore it.

PR-URL: nodejs#24554
Fixes: nodejs#24543
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 12, 2019 
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was
missing, restore it.

PR-URL: nodejs#24554
Fixes: nodejs#24543
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 16, 2019 
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was
missing, restore it.

PR-URL: #24554
Fixes: #24543
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

May 29, 2019