Home Original page

buffer: simplify code by BridgeAR · Pull Request #25151 · nodejs/node

@BridgeAR 

This refactors some code for simplicity. It also removes a call
indirection used in the buffers custom inspect function.

addaleax

mscdex

mscdex

addaleax

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 23, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Dec 24, 2018 
This refactors some code for simplicity. It also removes a call
indirection used in the buffers custom inspect function.

PR-URL: nodejs#25151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018 
This refactors some code for simplicity. It also removes a call
indirection used in the buffers custom inspect function.

PR-URL: #25151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018 
This refactors some code for simplicity. It also removes a call
indirection used in the buffers custom inspect function.

PR-URL: #25151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019 
This refactors some code for simplicity. It also removes a call
indirection used in the buffers custom inspect function.

PR-URL: nodejs#25151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>