Home Original page

src: use ZCtxt as a source for v8::Isolates by r-52 · Pull Request #2547 · nodejs/node

@romankl 

Other methods like `After` already use ZCtxt as the source for
Enviroment/ v8::Isolate objects, this commit applies the same style
to the other missing methods (`After sync` and `Write`)

@Fishrock123 added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Aug 25, 2015

Fishrock123 pushed a commit that referenced this pull request

Sep 14, 2015 
Other methods like `After` already use ZCtxt as the source for
Enviroment/ v8::Isolate objects, this commit applies the same style
to the other missing methods (`After sync` and `Write`)

PR-URL: #2547
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@r-52 r-52 deleted the zlib-ctxt branch

September 14, 2015 21:02

Fishrock123 pushed a commit that referenced this pull request

Sep 15, 2015 
Other methods like `After` already use ZCtxt as the source for
Enviroment/ v8::Isolate objects, this commit applies the same style
to the other missing methods (`After sync` and `Write`)

PR-URL: #2547
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

rvagg pushed a commit that referenced this pull request

Sep 15, 2015 
Other methods like `After` already use ZCtxt as the source for
Enviroment/ v8::Isolate objects, this commit applies the same style
to the other missing methods (`After sync` and `Write`)

PR-URL: #2547
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@rvagg rvagg mentioned this pull request

Sep 15, 2015

@rvagg rvagg mentioned this pull request

Sep 22, 2015

This was referenced

Dec 20, 2023