Home Original page

streams: refactor LazyTransform to internal/ by brendanashworth · Pull Request #2566 · nodejs/node

@brendanashworth 

This commit refactors LazyTransform from the crypto implementation
(lib/crypto.js) into an internal module (not publicy accessible) in
internal/streams/LazyTransform.js. This promotes a more modular core
design and removes code bloat in crypto, as LazyTransform didn't
specifically have anything to do with cryptography, but rather a fast
way to support two APIs on a stream.

@brendanashworth added crypto

Issues and PRs related to the crypto subsystem.

stream

Issues and PRs related to the stream subsystem.

labels

Aug 26, 2015

@brendanashworth

brendanashworth added a commit that referenced this pull request

Sep 15, 2015 
This commit refactors LazyTransform from the crypto implementation
(lib/crypto.js) into an internal module (not publicy accessible) in
internal/streams/lazy_transform.js. This promotes a more modular core
design and removes code bloat in crypto, as LazyTransform didn't
specifically have anything to do with cryptography, but rather a fast
way to support two APIs on a stream.

PR-URL: #2566
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

brendanashworth added a commit that referenced this pull request

Sep 15, 2015 
This commit refactors LazyTransform from the crypto implementation
(lib/crypto.js) into an internal module (not publicy accessible) in
internal/streams/lazy_transform.js. This promotes a more modular core
design and removes code bloat in crypto, as LazyTransform didn't
specifically have anything to do with cryptography, but rather a fast
way to support two APIs on a stream.

PR-URL: #2566
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

@rvagg rvagg mentioned this pull request

Sep 15, 2015

brendanashworth added a commit that referenced this pull request

Sep 15, 2015 
This commit refactors LazyTransform from the crypto implementation
(lib/crypto.js) into an internal module (not publicy accessible) in
internal/streams/lazy_transform.js. This promotes a more modular core
design and removes code bloat in crypto, as LazyTransform didn't
specifically have anything to do with cryptography, but rather a fast
way to support two APIs on a stream.

PR-URL: #2566
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

@rvagg rvagg mentioned this pull request

Sep 22, 2015