Home Original page

inspector: forward errors from InspectorConsoleCall by addaleax · Pull Request #26113 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

inspector

Issues and PRs related to the V8 inspector protocol

labels

Feb 14, 2019

@addaleax 

Do not assume that entering JS cannot fail.

joyeecheung

JungMinu

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 15, 2019

addaleax added a commit that referenced this pull request

Feb 17, 2019 
Do not assume that entering JS cannot fail.

PR-URL: #26113
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request

Feb 17, 2019 
Do not assume that entering JS cannot fail.

PR-URL: #26113
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this pull request

Feb 28, 2019 
Do not assume that entering JS cannot fail.

PR-URL: #26113
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>