Home Original page

src: add debug CHECKs against empty handles by addaleax · Pull Request #26125 · nodejs/node

@addaleax 

These checks were useful while investigating other issues;
using empty `Local<>`s can be very un-debuggable, because that
typically does not lead to assertions with debugging information
but rather crashes based on accessing invalid memory.

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Feb 15, 2019

@addaleax addaleax added lib / src

Issues and PRs related to general changes in the lib or src directory.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Feb 15, 2019

addaleax added a commit that referenced this pull request

Feb 17, 2019 
These checks were useful while investigating other issues;
using empty `Local<>`s can be very un-debuggable, because that
typically does not lead to assertions with debugging information
but rather crashes based on accessing invalid memory.

PR-URL: #26125
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request

Feb 17, 2019 
These checks were useful while investigating other issues;
using empty `Local<>`s can be very un-debuggable, because that
typically does not lead to assertions with debugging information
but rather crashes based on accessing invalid memory.

PR-URL: #26125
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this pull request

Feb 28, 2019 
These checks were useful while investigating other issues;
using empty `Local<>`s can be very un-debuggable, because that
typically does not lead to assertions with debugging information
but rather crashes based on accessing invalid memory.

PR-URL: #26125
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>