Home Original page

tools: refactor for arrow callbacks and trailing commas by Trott · Pull Request #26394 · nodejs/node

added 2 commits

March 1, 2019 22:47
* standardize on arrow functions for callbacks
* standaradize on trailing commas for multiline arrays
Enable ESLint rules for trailing commas and arrow callbacks in tools
directory. These rules are also in place in the benchmark directory.

@nodejs-github-bot nodejs-github-bot added doc

Issues and PRs related to the documentations.

tools

Issues and PRs related to the tools directory.

labels

Mar 2, 2019

richardlau

antsmartian

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 2, 2019

BridgeAR

Trott added a commit to Trott/io.js that referenced this pull request

Mar 4, 2019 
* standardize on arrow functions for callbacks
* standaradize on trailing commas for multiline arrays

PR-URL: nodejs#26394
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Trott added a commit to Trott/io.js that referenced this pull request

Mar 4, 2019 
Enable ESLint rules for trailing commas and arrow callbacks in tools
directory. These rules are also in place in the benchmark directory.

PR-URL: nodejs#26394
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 12, 2019 
* standardize on arrow functions for callbacks
* standaradize on trailing commas for multiline arrays

PR-URL: nodejs#26394
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 12, 2019 
Enable ESLint rules for trailing commas and arrow callbacks in tools
directory. These rules are also in place in the benchmark directory.

PR-URL: nodejs#26394
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@Trott Trott deleted the refactor-tools branch

January 13, 2022 22:51