Home Original page

benchmark: refactor buffer benchmarks by BridgeAR · Pull Request #26418 · nodejs/node

@nodejs-github-bot added benchmark

Issues and PRs related to the benchmark subsystem.

buffer

Issues and PRs related to the buffer subsystem.

labels

Mar 4, 2019

mscdex

mscdex previously requested changes Mar 4, 2019

@BridgeAR 

Currently the buffer benchmarks take significantly too long to
complete. This drastically reduces the overall runtime by removing
obsolete checked variations and reducing the iteration count.

It also improves the benchmarks by removing the deprecated
`new Buffer(size)` usage and some other small improvements.

BridgeAR

BridgeAR

BridgeAR

BridgeAR

BridgeAR

This was referenced

Jun 4, 2019

apapirovski

@Trott Trott removed the tsc-agenda

Issues and PRs to discuss during the meetings of the TSC.

label

Jun 20, 2019

Trott pushed a commit to Trott/io.js that referenced this pull request

Jun 20, 2019 
Currently the buffer benchmarks take significantly too long to
complete. This drastically reduces the overall runtime by removing
obsolete checked variations and reducing the iteration count.

It also improves the benchmarks by removing the deprecated
`new Buffer(size)` usage and some other small improvements.

PR-URL: nodejs#26418
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request

Jul 2, 2019 
Currently the buffer benchmarks take significantly too long to
complete. This drastically reduces the overall runtime by removing
obsolete checked variations and reducing the iteration count.

It also improves the benchmarks by removing the deprecated
`new Buffer(size)` usage and some other small improvements.

PR-URL: #26418
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

This was referenced

Jul 3, 2019

@BridgeAR BridgeAR deleted the refactor-buffer-benchmarks branch

January 20, 2020 12:03