Home Original page

test: de-flake test-dns-idna2008.js by refack · Pull Request #26473 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Mar 6, 2019

@refack refack added the dns

Issues and PRs related to the dns subsystem.

label

Mar 6, 2019

gireeshpunathil

richardlau

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 7, 2019

@Trott Trott added fast-track

PRs that do not need to wait for 72 hours to land.

and removed fast-track

PRs that do not need to wait for 72 hours to land.

labels

Mar 7, 2019

joyeecheung

@refack 

* use known well-behaved DNS server
* force pass on ESERVFAIL

PR-URL: nodejs#26473
Fixes: nodejs#25870
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@refack refack removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 9, 2019

@refack refack deleted the fix-idna2008-test branch

March 9, 2019 15:14

refack added a commit to refack/node that referenced this pull request

Mar 12, 2019 
Fixes a bug I introduced in 9613221

PR-URL: nodejs#26570
Refs: nodejs#25870
Refs: nodejs#26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

BridgeAR pushed a commit that referenced this pull request

Mar 13, 2019 
* use known well-behaved DNS server
* force pass on ESERVFAIL

PR-URL: #26473
Fixes: #25870
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Mar 13, 2019 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

BridgeAR pushed a commit that referenced this pull request

Mar 14, 2019 
* use known well-behaved DNS server
* force pass on ESERVFAIL

PR-URL: #26473
Fixes: #25870
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Mar 14, 2019 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 14, 2019 
Fixes a bug I introduced in 9613221

PR-URL: nodejs#26570
Refs: nodejs#25870
Refs: nodejs#26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

BridgeAR pushed a commit that referenced this pull request

Mar 14, 2019 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>