Home Original page

timers: remove dead code and simplify args check by BridgeAR · Pull Request #26555 · nodejs/node

@BridgeAR 

The `setUnrefTimeout` function is never called with more arguments
than two. So quite some code was dead and never used. This removes
that code and simplifies the args check not to coerce objects to
booleans.

@nodejs-github-bot added the timers

Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

label

Mar 10, 2019

bnoordhuis

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 12, 2019

tniessen

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Mar 13, 2019 
The `setUnrefTimeout` function is never called with more arguments
than two. So quite some code was dead and never used. This removes
that code and simplifies the args check not to coerce objects to
booleans.

PR-URL: nodejs#26555
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit that referenced this pull request

Mar 14, 2019 
The `setUnrefTimeout` function is never called with more arguments
than two. So quite some code was dead and never used. This removes
that code and simplifies the args check not to coerce objects to
booleans.

PR-URL: #26555
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Mar 14, 2019 
The `setUnrefTimeout` function is never called with more arguments
than two. So quite some code was dead and never used. This removes
that code and simplifies the args check not to coerce objects to
booleans.

PR-URL: nodejs#26555
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit that referenced this pull request

Mar 14, 2019 
The `setUnrefTimeout` function is never called with more arguments
than two. So quite some code was dead and never used. This removes
that code and simplifies the args check not to coerce objects to
booleans.

PR-URL: #26555
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@BridgeAR BridgeAR deleted the remove-dead-timers-code branch

January 20, 2020 11:55

This was referenced

Mar 11, 2021

This was referenced

May 25, 2021

This was referenced

Apr 7, 2022

This was referenced

Jan 31, 2023