Home Original page

http2: reduce usage of public require('util') in core.js by Naturalclar · Pull Request #26789 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@Naturalclar

This PR is part of issue #26546

Replaced usage of public require('util')

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

shisama

BridgeAR

@BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 22, 2019

@BridgeAR

@BridgeAR

@Naturalclar seems like there are some conflicts. Would you be so kind and rebase this to resolve them and to force push afterwards? Thanks!

@BridgeAR BridgeAR removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 24, 2019

jasnell

@ZYSzys

@Naturalclar oh, thanks for your PR first, but I'm sorry to say that this seems to be duplicated with #26784 (which was landed already)

@BridgeAR

@Naturalclar thanks for the PR and sorry that this can not land. As @ZYSzys pointed out this already landed in Node.js as two PRs were working on the same file.

Please keep up the good work!

Labels

http2

Issues or PRs related to the http2 subsystem.