Home Original page

test: make module test pass with NODE_PENDING_DEPRECATION by addaleax · Pull Request #27019 · nodejs/node

@addaleax 

Some people set the `NODE_PENDING_DEPRECATION` environment variable
globally. This makes the test added in 115f0f5
pass when that is the case.

Refs: nodejs#26823

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Mar 30, 2019

richardlau

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 31, 2019

MylesBorins

ZYSzys pushed a commit that referenced this pull request

Apr 3, 2019 
Some people set the `NODE_PENDING_DEPRECATION` environment variable
globally. This makes the test added in 115f0f5
pass when that is the case.

Refs: #26823

PR-URL: #27019
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@addaleax addaleax deleted the test-module-loader-pending branch

April 3, 2019 13:59

BethGriggs pushed a commit that referenced this pull request

Apr 4, 2019 
Some people set the `NODE_PENDING_DEPRECATION` environment variable
globally. This makes the test added in 115f0f5
pass when that is the case.

Refs: #26823

PR-URL: #27019
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019 
Some people set the `NODE_PENDING_DEPRECATION` environment variable
globally. This makes the test added in 115f0f5
pass when that is the case.

Refs: #26823

PR-URL: #27019
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 10, 2019 
Some people set the `NODE_PENDING_DEPRECATION` environment variable
globally. This makes the test added in 115f0f5
pass when that is the case.

Refs: #26823

PR-URL: #27019
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>