Home Original page

src: use ArrayBufferAllocator::Create in node_worker.cc by addaleax · Pull Request #27251 · nodejs/node

Conversation

@addaleax

Refs: #27220

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

worker

Issues and PRs related to Worker support.

labels

Apr 16, 2019

bnoordhuis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's another instance in StartNodeWithLoopAndArgs() that could also be switched over? Or is that already covered by another PR?

@addaleax

@nodejs-github-bot

cjihrig

joyeecheung

jasnell

@addaleax

addaleax added a commit that referenced this pull request

Apr 18, 2019 
Refs: #27220

PR-URL: #27251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Apr 23, 2019

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

worker

Issues and PRs related to Worker support.