Home Original page

[v11.x] deps: V8: backport 61f4c22 by addaleax · Pull Request #27259 · nodejs/node

@addaleax 

The differences to the original patch are the replacement of
`i::IsIdentifier...()` with `unicode_cache_.IsIdentifier...()`,
because the former is not available on Node.js v11.x, as well
as the omitted `no_gc` argument for `GetFlatContent()`.

Original commit message:

    Assume flat string when checking CompileFunctionInContext arguments.

    R=jkummerow@chromium.org

    Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc
    Reviewed-on: https://chromium-review.googlesource.com/c/1388533
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#58562}

Refs: v8/v8@61f4c22
Fixes: nodejs#27256

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

v11.x v8 engine

Issues and PRs related to the V8 dependency.

labels

Apr 16, 2019

@addaleax addaleax changed the title deps: V8: backport 61f4c22 [v11.x] deps: V8: backport 61f4c22

Apr 16, 2019

@addaleax addaleax removed the build

Issues and PRs related to build files or the CI.

label

Apr 16, 2019

joyeecheung

codebytere

codebytere pushed a commit that referenced this pull request

Apr 29, 2019 
The differences to the original patch are the replacement of
`i::IsIdentifier...()` with `unicode_cache_.IsIdentifier...()`,
because the former is not available on Node.js v11.x, as well
as the omitted `no_gc` argument for `GetFlatContent()`.

Original commit message:

    Assume flat string when checking CompileFunctionInContext arguments.

    R=jkummerow@chromium.org

    Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc
    Reviewed-on: https://chromium-review.googlesource.com/c/1388533
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58562}

Refs: v8/v8@61f4c22
Fixes: #27256

PR-URL: #27259
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

@addaleax addaleax deleted the v8-compile-function-identifier branch

February 20, 2020 00:28