deps: backport ICU-20558 to fix Intl crasher by srl295 · Pull Request #27415 · nodejs/node
srl295
marked this pull request as ready for review
- Floating patch for ICU 63.x and 64.x - fixing crash in Intl when ICU data not found. - Regression test from refack included. Background: - ICU-13778 (landed in ICU 63.1) fixed a bug but added a regression. - a recent v8 land in Node v12 (which one?) exposes this bug to cause a crash when ICU data is not found. ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20558 Backport of: unicode-org/icu#632 (Commit not landed yet in ICU) Fixes: nodejs#27379 Co-authored-by: Refael Ackermann <refack@gmail.com>
This was referenced
Apr 26, 2019targos pushed a commit to targos/node that referenced this pull request
Apr 27, 2019
- Floating patch for ICU 63.x and 64.x - fixing crash in Intl when ICU data not found. - Regression test from refack included. Background: - ICU-13778 (landed in ICU 63.1) fixed a bug but added a regression. - a recent v8 land in Node v12 (which one?) exposes this bug to cause a crash when ICU data is not found. ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20558 Backport of: unicode-org/icu#632 Fixes: nodejs#27379 Co-authored-by: Refael Ackermann <refack@gmail.com> PR-URL: nodejs#27415 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos pushed a commit that referenced this pull request
Apr 27, 2019
- Floating patch for ICU 63.x and 64.x - fixing crash in Intl when ICU data not found. - Regression test from refack included. Background: - ICU-13778 (landed in ICU 63.1) fixed a bug but added a regression. - a recent v8 land in Node v12 (which one?) exposes this bug to cause a crash when ICU data is not found. ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20558 Backport of: unicode-org/icu#632 Fixes: #27379 Co-authored-by: Refael Ackermann <refack@gmail.com> PR-URL: #27415 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos added a commit that referenced this pull request
Apr 27, 2019
Notable changes:
* intl:
* Update ICU to 64.2. This adds support for Japanese Era (Reiwa).
#27361
* Fixes a bug in ICU that affected Node.js 12.0.0 in the case where
`new Date().toLocaleString()` was called with a non-default locale.
#27415
* C++ API:
* Added an `Environment` overload of `EmitAsyncDestroy`.
#27255
PR-URL: TODO
targos added a commit that referenced this pull request
Apr 29, 2019
Notable changes:
* intl:
* Update ICU to 64.2. This adds support for Japanese Era (Reiwa).
#27361
* Fixes a bug in ICU that affected Node.js 12.0.0 in the case where
`new Date().toLocaleString()` was called with a non-default locale.
#27415
* C++ API:
* Added an overload of `EmitAsyncDestroy` that can be used during
garbage collection.
#27255
PR-URL: #27440
targos added a commit that referenced this pull request
Apr 29, 2019
Notable changes:
* intl:
* Update ICU to 64.2. This adds support for Japanese Era (Reiwa).
#27361
* Fixes a bug in ICU that affected Node.js 12.0.0 in the case where
`new Date().toLocaleString()` was called with a non-default locale.
#27415
* C++ API:
* Added an overload of `EmitAsyncDestroy` that can be used during
garbage collection.
#27255
PR-URL: #27440
BethGriggs pushed a commit that referenced this pull request
May 10, 2019
- Floating patch for ICU 63.x and 64.x - fixing crash in Intl when ICU data not found. - Regression test from refack included. Background: - ICU-13778 (landed in ICU 63.1) fixed a bug but added a regression. - a recent v8 land in Node v12 (which one?) exposes this bug to cause a crash when ICU data is not found. ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20558 Backport of: unicode-org/icu#632 Fixes: #27379 Co-authored-by: Refael Ackermann <refack@gmail.com> PR-URL: #27415 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
MylesBorins pushed a commit that referenced this pull request
May 16, 2019
- Floating patch for ICU 63.x and 64.x - fixing crash in Intl when ICU data not found. - Regression test from refack included. Background: - ICU-13778 (landed in ICU 63.1) fixed a bug but added a regression. - a recent v8 land in Node v12 (which one?) exposes this bug to cause a crash when ICU data is not found. ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20558 Backport of: unicode-org/icu#632 Fixes: #27379 Co-authored-by: Refael Ackermann <refack@gmail.com> PR-URL: #27415 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This was referenced
May 29, 2019This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters