Home Original page

test: remove unneeded `--expose-internals` by Trott · Pull Request #27608 · nodejs/node

@Trott 

test/wpt/test-timers.js does not appear to need the `--expose-internals`
flag. Remove it.

joyeecheung

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 8, 2019

richardlau

Trott added a commit to Trott/io.js that referenced this pull request

May 10, 2019 
test/wpt/test-timers.js does not appear to need the `--expose-internals`
flag. Remove it.

PR-URL: nodejs#27608
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos pushed a commit that referenced this pull request

May 11, 2019 
test/wpt/test-timers.js does not appear to need the `--expose-internals`
flag. Remove it.

PR-URL: #27608
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@Trott Trott deleted the remove-uneeded-flag branch

January 13, 2022 22:51