Home Original page

src: fix segfault handling/RegisterSignalHandler by addaleax · Pull Request #27775 · nodejs/node

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

May 20, 2019

bnoordhuis

@Trott Trott added the wip

Issues and PRs that are still a work in progress.

label

Jun 1, 2019

@addaleax addaleax added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

review wanted

PRs that need reviews.

and removed wip

Issues and PRs that are still a work in progress.

labels

Jun 9, 2019 
This macro is only defined when building Node.js, so addons cannot
use it as a way of detecting feature availability.
Without this, we would re-enter the signal handler immediately
after re-raising the signal, leading to an infinite loop.
This is not easily implementable, and should be explicitly disallowed.
Ensure coverage for the different combinations of arguments.

addaleax added a commit that referenced this pull request

Jun 14, 2019 
This macro is only defined when building Node.js, so addons cannot
use it as a way of detecting feature availability.

PR-URL: #27775
Refs: #27246
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax added a commit that referenced this pull request

Jun 14, 2019 
Without this, we would re-enter the signal handler immediately
after re-raising the signal, leading to an infinite loop.

PR-URL: #27775
Refs: #27246
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax added a commit that referenced this pull request

Jun 14, 2019 
This is not easily implementable, and should be explicitly disallowed.

PR-URL: #27775
Refs: #27246
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax added a commit that referenced this pull request

Jun 14, 2019 
Ensure coverage for the different combinations of arguments.

PR-URL: #27775
Refs: #27246
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

This was referenced

Jun 14, 2019