add missing assert from 0.12 merge by julianduque · Pull Request #2782 · nodejs/node
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 35.1k
Closed
julianduque wants to merge 1 commit intonodejs:masterfrom
Closed
add missing assert from 0.12 merge#2782
julianduque wants to merge 1 commit intonodejs:masterfrom
add missing assert from 0.12 merge#2782
julianduque wants to merge 1 commit intonodejs:masterfrom
Conversation
Copy link
Contributor
julianduque
commented
Sep 9, 2015
julianduque
commented
An assert check is missing from 0.12 merge, adding it back
Reference: #2780
An assert check is missing from 0.12 merge, adding it back
label
Sep 9, 2015
Copy link
Member
rvagg
commented
Sep 10, 2015
rvagg commented
Sep 10, 2015lgtm! a good one for 4.0.1
Copy link
Member
targos
commented
Sep 10, 2015
targos commented
Sep 10, 2015cc @bnoordhuis since he removed the line in a60056d
Copy link
Contributor
cjihrig
commented
Nov 18, 2015
cjihrig commented
Nov 18, 2015Closing based on the conversation in #2780. Please let me know if this needs to be revisited.
cjihrig
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 participants