Home Original page

test: remove check for valid hostname in test-dns.js by Trott · Pull Request #2785 · nodejs/node

@Trott added the test

Issues and PRs related to the tests.

label

Sep 9, 2015

@mscdex mscdex added the dns

Issues and PRs related to the dns subsystem.

label

Sep 9, 2015

@Trott 

Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: nodejs#2468

@Trott Trott mentioned this pull request

Sep 10, 2015

Trott added a commit that referenced this pull request

Sep 10, 2015 
Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: #2468
PR-URL: #2785
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Trott added a commit that referenced this pull request

Sep 11, 2015 
Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: #2468
PR-URL: #2785
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Trott added a commit that referenced this pull request

Sep 12, 2015 
Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: #2468
PR-URL: #2785
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@rvagg rvagg mentioned this pull request

Sep 12, 2015

@Trott Trott mentioned this pull request

Sep 12, 2015

@rvagg rvagg mentioned this pull request

Sep 22, 2015

@Trott Trott deleted the test-dns-hostname-check branch

January 9, 2022 22:03