deps: cherry-pick 6da51b4 from v8's upstream by indutny · Pull Request #2801 · nodejs/node
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{nodejs#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
indutny added a commit that referenced this pull request
Sep 10, 2015
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: #2463
PR-URL: #2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
indutny
deleted the
fix/buffer-iteration-slow
branch
indutny added a commit that referenced this pull request
Sep 11, 2015
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: #2463
PR-URL: #2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 11, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 11, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 12, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 12, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
rvagg
mentioned this pull request
oleavr added a commit to frida/v8 that referenced this pull request
Sep 12, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 12, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 12, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 12, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 12, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Sep 12, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
rvagg
mentioned this pull request
oleavr added a commit to frida/v8 that referenced this pull request
Dec 26, 2015
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit to frida/v8 that referenced this pull request
Aug 11, 2016
Cherry-picked from Node.js:
commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d
Author: Fedor Indutny <fedor@indutny.com>
Date: Thu Sep 10 12:26:50 2015 -0700
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: nodejs/node#2463
PR-URL: nodejs/node#2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters