Home Original page

test: check custom inspection truncation in assert by Trott · Pull Request #28234 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Jun 14, 2019

@Trott Trott added the assert

Issues and PRs related to the assert subsystem.

label

Jun 14, 2019

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 15, 2019

@Trott 

The assert module has some truncation logic in a custom inspect
function. This was not covered in tests. Add tests to cover it.

PR-URL: nodejs#28234
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@Trott Trott deleted the check-truncation branch

June 18, 2019 18:17

targos pushed a commit that referenced this pull request

Jul 2, 2019 
The assert module has some truncation logic in a custom inspect
function. This was not covered in tests. Add tests to cover it.

PR-URL: #28234
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

This was referenced

Jul 3, 2019