Home Original page

http: default Agent.getName to 'localhost' by ahoym · Pull Request #2825 · nodejs/node

@ahoym 

Refactor out the if/else statement checking for option.host.
Add whitespace to make concatenation chunks more readable and
consistent with the https version of Agent.getName().

@mscdex added the http

Issues or PRs related to the http subsystem.

label

Sep 11, 2015

Trott pushed a commit that referenced this pull request

Sep 15, 2015 
Refactor out the if/else statement checking for option.host.
Add whitespace to make concatenation chunks more readable and
consistent with the https version of Agent.getName().

PR-URL: #2825
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@ahoym ahoym deleted the cleanup-agent.getName branch

September 16, 2015 00:08

Fishrock123 pushed a commit that referenced this pull request

Sep 16, 2015 
Refactor out the if/else statement checking for option.host.
Add whitespace to make concatenation chunks more readable and
consistent with the https version of Agent.getName().

PR-URL: #2825
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@rvagg rvagg mentioned this pull request

Sep 22, 2015