Home Original page

test: fix flaky test-worker-debug by addaleax · Pull Request #28307 · nodejs/node

@addaleax 

Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: nodejs#28299
Fixes: nodejs#28106

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Jun 19, 2019

@addaleax addaleax added flaky-test

Issues and PRs related to the tests with unstable failures on the CI.

fast-track

PRs that do not need to wait for 72 hours to land.

worker

Issues and PRs related to Worker support.

inspector

Issues and PRs related to the V8 inspector protocol

labels

Jun 19, 2019

richardlau

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 19, 2019

danbev pushed a commit that referenced this pull request

Jun 20, 2019 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

@addaleax addaleax deleted the test-worker-debug-fix branch

June 20, 2019 20:38

targos pushed a commit that referenced this pull request

Jul 2, 2019 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

This was referenced

Jul 3, 2019