http: emit ECONNRESET if no 'aborted' listener by ronag · Pull Request #28677

http: emit ECONNRESET if no 'aborted' listener by ronag · Pull Request #28677 · nodejs/node

added the http

Issues or PRs related to the http subsystem.

label

Jul 14, 2019

ronag changed the title ~~http: emit ECONNRESET if not aborted listener~~ http: emit ECONNRESET if no aborted listener

Jul 14, 2019

ronag changed the title ~~http: emit ECONNRESET if no aborted listener~~ http: emit ECONNRESET if no 'aborted' listener

Jul 14, 2019

mcollina added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jul 14, 2019

Trott added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Sep 19, 2019

ronag mentioned this pull request

Sep 23, 2019

This was referenced

Apr 22, 2020

ronag mentioned this pull request

Apr 30, 2020

4 tasks

ronag added a commit that referenced this pull request

May 10, 2020

Server requests aka. IncomingMessage emits 'aborted'
instead of 'error' which causes confusion when
the object is used as a regular stream, i.e. if
functions working on streams are passed a
server request object they might not work properly
unless they take this into account.

Refs: nodejs/web-server-frameworks#41

PR-URL: #33172
Fixes: #28172
Refs: #28677
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>