Restore missing backtick in Buffer documentation by joepie91 · Pull Request #2881 · nodejs/node
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 35.1k
Closed
joepie91 wants to merge 1 commit intonodejs:masterfrom
Closed
Restore missing backtick in Buffer documentation#2881
joepie91 wants to merge 1 commit intonodejs:masterfrom
Restore missing backtick in Buffer documentation#2881
joepie91 wants to merge 1 commit intonodejs:masterfrom
Conversation
joepie91
mentioned this pull request
Copy link
Contributor
Fishrock123
commented
Sep 15, 2015
Fishrock123 commented
Sep 15, 2015@joepie91 Could you reformat the commit message to be something like "doc: add missing backtick in buffer.markdown`? (The "doc: " bit is the important bit!)
LGTM otherwise.
Copy link
Contributor Author
joepie91
commented
Sep 15, 2015
joepie91 commented
Sep 15, 2015Hmm. I'm actually not quite sure how to do that.
Also, perhaps it'd be a good idea to add the doc: prefix to the CONTRIBUTING.md explicitly - as it only seemed to refer to code contributions, I'd decided to omit it here.
Copy link
Contributor
Fishrock123
commented
Sep 15, 2015
Fishrock123 commented
Sep 15, 2015@joepie91 No problem. If you do git commit --amend you'll be able to edit your commit message. Then you can force-push the new commit up to here, along the lines of git push origin patch-1 --force. :)
joepie91
force-pushed
the
patch-1
branch
from
6fb5589 to
d42465e
Compare
Copy link
Contributor Author
joepie91
commented
Sep 15, 2015
joepie91 commented
Sep 15, 2015Okay, should be sorted now.
Copy link
Contributor
Fishrock123
commented
Sep 15, 2015
Fishrock123 commented
Sep 15, 2015Thanks, landed in 360d0fa!
Fishrock123
closed this
rvagg
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment