Restore missing backtick in Buffer documentation by joepie91 · Pull Request #2881 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@joepie91

Copy link

Contributor

Fixes the formatting.

@Fishrock123 Fishrock123 added the doc

Issues and PRs related to the documentations.

label

Sep 15, 2015

@Fishrock123

Copy link

Contributor

@joepie91 Could you reformat the commit message to be something like "doc: add missing backtick in buffer.markdown`? (The "doc: " bit is the important bit!)

LGTM otherwise.

@joepie91

Copy link

Contributor Author

Hmm. I'm actually not quite sure how to do that.

Also, perhaps it'd be a good idea to add the doc: prefix to the CONTRIBUTING.md explicitly - as it only seemed to refer to code contributions, I'd decided to omit it here.

@Fishrock123

Copy link

Contributor

@joepie91 No problem. If you do git commit --amend you'll be able to edit your commit message. Then you can force-push the new commit up to here, along the lines of git push origin patch-1 --force. :)

@joepie91

Copy link

Contributor Author

Okay, should be sorted now.

Fishrock123 pushed a commit that referenced this pull request

Sep 15, 2015
Fixes: #2880
PR-URL: #2881
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@Fishrock123

Copy link

Contributor

Thanks, landed in 360d0fa!

Fishrock123 pushed a commit that referenced this pull request

Sep 15, 2015
Fixes: #2880
PR-URL: #2881
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@Fishrock123 Fishrock123 mentioned this pull request

Sep 16, 2015

7 tasks

@rvagg rvagg mentioned this pull request

Sep 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc

Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joepie91 @Fishrock123