Home Original page

fs: validate writev fds consistently by cjihrig · Pull Request #29185 · nodejs/node

@nodejs-github-bot added the fs

Issues and PRs related to the fs subsystem / file system.

label

Aug 17, 2019

addaleax

@ZYSzys ZYSzys added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 18, 2019

gengjiawen

antsmartian

@cjihrig 

This commit updates the recently added writev methods
to validate file descriptors like the other fs methods do.

PR-URL: nodejs#29185
Refs: nodejs#25925
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos pushed a commit that referenced this pull request

Aug 20, 2019 
This commit updates the recently added writev methods
to validate file descriptors like the other fs methods do.

PR-URL: #29185
Refs: #25925
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

This was referenced

Aug 20, 2019