Home Original page

[x] http2: compat ERR_STREAM_ALREADY_FINISHED by ronag · Pull Request #29229 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ronag

Copy link

Member

@ronag ronag commented

Aug 20, 2019

Make http/2 compat end() match Writable and http/1.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
bricss reacted with thumbs up emoji

@nodejs-github-bot nodejs-github-bot added the http2

Issues or PRs related to the http2 subsystem.

label

Aug 20, 2019

@ronag ronag force-pushed the http2-already-finished branch from dfd3c30 to 3935035 Compare

August 20, 2019 16:54

@jasnell jasnell added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Aug 20, 2019

@ronag ronag force-pushed the http2-already-finished branch from 3935035 to 2f4bde0 Compare

August 20, 2019 17:30

@jasnell jasnell requested review from addaleax and mcollina

August 20, 2019 17:34

@ronag ronag force-pushed the http2-already-finished branch 2 times, most recently from 0e21efb to dc9cd5e Compare

August 20, 2019 19:42

@jasnell

Copy link

Member

jasnell commented

Aug 22, 2019

Would like to see a CITGM run before landing

@ronag ronag force-pushed the http2-already-finished branch from dc9cd5e to 7b11584 Compare

August 22, 2019 19:03 
Make http/2 compat end() match Writable and http/1.

@ronag ronag force-pushed the http2-already-finished branch from 7b11584 to 0605719 Compare

August 22, 2019 22:45

@ronag

Copy link

Member Author

ronag commented

Sep 20, 2019

This should probably wait for #24347 before merging.

@ronag

Copy link

Member Author

ronag commented

Dec 15, 2019

I'm closing this for now. It's been blocked for quite a while by #24347 and the problem is currently tracked in #29829. I'll re-open if/when it becomes relevant again.

@ronag ronag closed this

Dec 15, 2019

@ronag ronag changed the title http2: compat ERR_STREAM_ALREADY_FINISHED [x] http2: compat ERR_STREAM_ALREADY_FINISHED

Dec 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@trivikr trivikr trivikr approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@addaleax addaleax Awaiting requested review from addaleax

Assignees

No one assigned

Labels

http2

Issues or PRs related to the http2 subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag @jasnell @nodejs-github-bot @Trott @trivikr