Home Original page

src: make ELDHistogram a HandleWrap by addaleax · Pull Request #29317 · nodejs/node

@addaleax 

This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Aug 25, 2019

@addaleax addaleax added perf_hooks

Issues and PRs related to the implementation of the Performance Timing API.

and removed lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Aug 25, 2019

@addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 7, 2019

Trott pushed a commit that referenced this pull request

Sep 8, 2019 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: #29317
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Sep 20, 2019 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: #29317
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to addaleax/node that referenced this pull request

Sep 21, 2019

bcoe pushed a commit that referenced this pull request

Sep 21, 2019 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request

Sep 23, 2019 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Sep 25, 2019 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: #29317
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Sep 25, 2019 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

This was referenced

Sep 25, 2019

This was referenced

Sep 26, 2019

addaleax added a commit to nodejs/quic that referenced this pull request

Sep 29, 2019 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: nodejs/node#29317
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to nodejs/quic that referenced this pull request

Sep 29, 2019 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

jasnell pushed a commit to nodejs/quic that referenced this pull request

Oct 1, 2019 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: nodejs/node#29317
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit to nodejs/quic that referenced this pull request

Oct 1, 2019 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax added a commit to nodejs/quic that referenced this pull request

Oct 2, 2019 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: nodejs/node#29317
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to nodejs/quic that referenced this pull request

Oct 2, 2019 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

jasnell pushed a commit to nodejs/quic that referenced this pull request

Oct 2, 2019 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: nodejs/node#29317
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit to nodejs/quic that referenced this pull request

Oct 2, 2019 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@Qard Qard mentioned this pull request

Dec 22, 2019

4 tasks