src: disconnect inspector before exiting out of fatal exception by joyeecheung · Pull Request #29611

src: disconnect inspector before exiting out of fatal exception by joyeecheung · Pull Request #29611 · nodejs/node

So that coverage, .etc are properly written in case of a normal
fatal exception.

nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Sep 19, 2019

joyeecheung added errors

Issues and PRs related to JavaScript errors originated in Node.js core.

coverage

Issues and PRs related to native coverage support.

labels

Sep 19, 2019

bcoe approved these changes Sep 22, 2019

danbev added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 23, 2019

bcoe pushed a commit to bcoe/node-1 that referenced this pull request

Sep 24, 2019

So that coverage, .etc are properly written in case of a normal
fatal exception.

PR-URL: nodejs#29611
Fixes: nodejs#29570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>

targos pushed a commit that referenced this pull request

Oct 1, 2019

So that coverage, .etc are properly written in case of a normal
fatal exception.

PR-URL: #29611
Fixes: #29570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>