Home Original page

errors: make sure all Node.js errors show their properties by BridgeAR · Pull Request #29677 · nodejs/node

@BridgeAR 

This improves Node.js errors by always showing the attached properties
when inspecting such an error. This applies especially to SystemError.
It did often not show any properties but now all properties will be
visible.
This is done in a mainly backwards compatible way. Instead of using
prototype getters and setters, the property is now set directly on the
error.

jasnell

mcollina

@BridgeAR 

It is not clear why some operations are done in a specific way. This
should be clarified to potentially simplify the implementation.

mcollina

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 1, 2019

boneskull

benjamingr

Trott pushed a commit that referenced this pull request

Oct 3, 2019 
This improves Node.js errors by always showing the attached properties
when inspecting such an error. This applies especially to SystemError.
It did often not show any properties but now all properties will be
visible.

This is done in a mainly backwards compatible way. Instead of using
prototype getters and setters, the property is now set directly on the
error.

PR-URL: #29677
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

BridgeAR added a commit that referenced this pull request

Oct 9, 2019 
This improves Node.js errors by always showing the attached properties
when inspecting such an error. This applies especially to SystemError.
It did often not show any properties but now all properties will be
visible.

This is done in a mainly backwards compatible way. Instead of using
prototype getters and setters, the property is now set directly on the
error.

PR-URL: #29677
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@BridgeAR BridgeAR deleted the awlays-show-error-properties branch

January 20, 2020 12:05

This was referenced

May 5, 2021