Home Original page

build: remove unused libatomic and librt on ppc64, s390x by sam-github · Pull Request #29727 · nodejs/node

@nodejs-github-bot added the tools

Issues and PRs related to the tools directory.

label

Sep 26, 2019

richardlau

BridgeAR

mhdawson

miladfarca

@sam-github sam-github changed the title tools: remove unused libatomic on ppc64, s390x tools: remove unused libatomic and librt on ppc64, s390x

Sep 27, 2019

@sam-github sam-github changed the title tools: remove unused libatomic and librt on ppc64, s390x build: remove unused libatomic and librt on ppc64, s390x

Sep 27, 2019

@Trott Trott removed the fast-track

PRs that do not need to wait for 72 hours to land.

label

Sep 28, 2019 
The library is not necessary for ppc64 or s390x. It does no harm with
some linkers, but devtoolset-6 creates runtime dependencies on all link
libraries, even unused ones.

Fixes: nodejs#27377
Fixes: nodejs#29718

@sam-github

sam-github added a commit that referenced this pull request

Oct 1, 2019 
The library is not necessary for ppc64 or s390x. It does no harm with
some linkers, but devtoolset-6 creates runtime dependencies on all link
libraries, even unused ones.

Fixes: #27377
Fixes: #29718

PR-URL: #29727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

sam-github added a commit that referenced this pull request

Oct 1, 2019 
PR-URL: #29727
Fixes: #27377
Fixes: #29718
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Oct 9, 2019 
The library is not necessary for ppc64 or s390x. It does no harm with
some linkers, but devtoolset-6 creates runtime dependencies on all link
libraries, even unused ones.

Fixes: #27377
Fixes: #29718

PR-URL: #29727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Oct 9, 2019 
PR-URL: #29727
Fixes: #27377
Fixes: #29718
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>