Home Original page

deps: enable unit data in small-icu by targos · Pull Request #29735 · nodejs/node

@targos 

The data are needed for new Intl.NumberFormat options added by V8.

Fixes: nodejs#29734

richardlau

JungMinu

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Sep 30, 2019

Trott pushed a commit that referenced this pull request

Sep 30, 2019 
The data are needed for new Intl.NumberFormat options added by V8.

Fixes: #29734

PR-URL: #29735
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

targos added a commit that referenced this pull request

Oct 1, 2019 
The data are needed for new Intl.NumberFormat options added by V8.

Fixes: #29734

PR-URL: #29735
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

targos added a commit that referenced this pull request

Oct 1, 2019 
Notable changes:

* build:
  * This release fixes a regression that prevented from building Node.js
    using the official source tarball.
    #29712
* deps:
  * Updated small-icu data to support "unit" style in the
    `Intl.NumberFormat` API.
    #29735

PR-URL: #29796

targos added a commit that referenced this pull request

Oct 1, 2019 
Notable changes:

* build:
  * This release fixes a regression that prevented from building Node.js
    using the official source tarball.
    #29712
* deps:
  * Updated small-icu data to support "unit" style in the
    `Intl.NumberFormat` API.
    #29735

PR-URL: #29796