n-api: add `napi_detach_arraybuffer` by legendecas · Pull Request #29768 · nodejs/node

n-api: add `napi_detach_arraybuffer` by legendecas · Pull Request #29768 · nodejs/node

added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

jasnell added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

legendecas changed the title ~~n-api: add napi_arraybuffer_detach~~ n-api: add napi_detach_arraybuffer

legendecas added a commit to legendecas/node that referenced this pull request

As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes nodejs#29674

PR-URL: nodejs#29768
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

richardlau pushed a commit that referenced this pull request

As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes: #29674
PR-URL: #29768
Backport-PR-URL: #33061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

richardlau added a commit that referenced this pull request

Notable changes:

- deps:
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    [#32982](#32982)
- n-api:
  * add `napi_detach_arraybuffer` (legendecas)
    [#29768](#29768)

richardlau added a commit that referenced this pull request

Notable changes:

- deps:
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  * add `napi_detach_arraybuffer` (legendecas)
    #29768

richardlau added a commit that referenced this pull request

Notable changes:

- deps:
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170

richardlau added a commit that referenced this pull request

Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170

richardlau added a commit that referenced this pull request

Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170

BethGriggs pushed a commit that referenced this pull request

Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170

cjihrig pushed a commit that referenced this pull request

Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170

tniessen added a commit to tniessen/node-addon-api that referenced this pull request

mhdawson pushed a commit to nodejs/node-addon-api that referenced this pull request

Superlokkus pushed a commit to Superlokkus/node-addon-api that referenced this pull request

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request

Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request

wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request

johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request