Home Original page

vm: SourceTextModule refactor by devsnek · Pull Request #29776 · nodejs/node

@devsnek added the vm

Issues and PRs related to the vm subsystem.

label

Sep 30, 2019

@devsnek devsnek removed the lib / src

Issues and PRs related to general changes in the lib or src directory.

label

Sep 30, 2019

targos

guybedford

JungMinu

BridgeAR

@devsnek @targos 

- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic

Closes nodejs#29030

Co-Authored-By: Michaël Zasso <targos@protonmail.com>

@devsnek devsnek added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 2, 2019

Trott pushed a commit that referenced this pull request

Oct 2, 2019 
- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic

Closes: #29030

Co-Authored-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #29776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

BridgeAR pushed a commit that referenced this pull request

Oct 9, 2019 
- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic

Closes: #29030

Co-Authored-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #29776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>