fs.watch throws exception when recursive is used in incompatible platform by exx8 · Pull Request #29947

fs.watch throws exception when recursive is used in incompatible platform by exx8 · Pull Request #29947 · nodejs/node

added errors

Issues and PRs related to JavaScript errors originated in Node.js core.

Issues and PRs related to the fs subsystem / file system.

labels

Oct 12, 2019

Trott added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Oct 16, 2019

addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 17, 2019

Eran Levin and others added 6 commits

January 24, 2020 05:56

Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>

Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>

Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>

Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 24, 2020

Trott pushed a commit that referenced this pull request

Jan 25, 2020

This pull request makes fs.watch throw exception,
whenever it is used in an incompatible platform.
For this change following changes were made to api:

1.a new error type has been introduced.
2.fs.watch has been changed accordingly.

Users who use recursive  on
non-windows and osx platforms,
will face a new exception.
For this reason, it's a breaking change.

Fixes: #29901

PR-URL: #29947
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jan 30, 2020

This makes sure this function stays backwards compatible in case
it's accessed through the binding directly.

Refs: #29947 (comment)

Backport-PR-URL: #31431
PR-URL: #30858
Refs: #30767
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

BethGriggs pushed a commit that referenced this pull request

Feb 6, 2020

This makes sure this function stays backwards compatible in case
it's accessed through the binding directly.

Refs: #29947 (comment)

Backport-PR-URL: #31431
PR-URL: #30858
Refs: #30767
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

molant added a commit to molant/cli that referenced this pull request

Feb 19, 2020

Use `chokidar` to track file system changes as soon it will throw an
error if the platform does not support `{ recursive: true }`.

Fix also an error where the built file was not being deleted when the
source was removed.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix react-native-community#989
Ref: nodejs/node#29947

molant added a commit to molant/cli that referenced this pull request

Feb 19, 2020

Use `chokidar` to track file system changes as soon it will throw an
error if the platform does not support `{ recursive: true }`.

Fix also an error where the built file was not being deleted when the
source was removed.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix react-native-community#989
Ref: nodejs/node#29947

thymikee pushed a commit to react-native-community/cli that referenced this pull request

Feb 20, 2020

Use `chokidar` to track file system changes as soon it will throw an
error if the platform does not support `{ recursive: true }`.

Fix also an error where the built file was not being deleted when the
source was removed.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #989
Ref: nodejs/node#29947