Home Original page

test: fix flaky doctool and test by Trott · Pull Request #29979 · nodejs/node

@nodejs-github-bot added doc

Issues and PRs related to the documentations.

tools

Issues and PRs related to the tools directory.

labels

Oct 15, 2019

@Trott Trott added the fast-track

PRs that do not need to wait for 72 hours to land.

label

Oct 15, 2019

@Trott Trott marked this pull request as ready for review

October 15, 2019 06:35

This was referenced

Oct 15, 2019

joyeecheung

gireeshpunathil

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 15, 2019

This was referenced

Oct 15, 2019

Fishrock123

targos pushed a commit that referenced this pull request

Nov 8, 2019 
Doctool tests have been failing a lot in CI on Win2008 R2. It appears
async functions and callback-based functions are being used in
combination such that the callback-based function cannot guarantee that
it will invoke its callback. Convert the callback-based functions to
async functions so we have one paradigm and reliable results.

PR-URL: #29979
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

targos pushed a commit that referenced this pull request

Nov 10, 2019 
Doctool tests have been failing a lot in CI on Win2008 R2. It appears
async functions and callback-based functions are being used in
combination such that the callback-based function cannot guarantee that
it will invoke its callback. Convert the callback-based functions to
async functions so we have one paradigm and reliable results.

PR-URL: #29979
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

richardlau pushed a commit to richardlau/node-1 that referenced this pull request

Apr 6, 2020 
Doctool tests have been failing a lot in CI on Win2008 R2. It appears
async functions and callback-based functions are being used in
combination such that the callback-based function cannot guarantee that
it will invoke its callback. Convert the callback-based functions to
async functions so we have one paradigm and reliable results.

Backport-PR-URL: nodejs#32642
PR-URL: nodejs#29979
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 6, 2020 
Doctool tests have been failing a lot in CI on Win2008 R2. It appears
async functions and callback-based functions are being used in
combination such that the callback-based function cannot guarantee that
it will invoke its callback. Convert the callback-based functions to
async functions so we have one paradigm and reliable results.

Backport-PR-URL: #32642
PR-URL: #29979
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@Trott Trott deleted the async-all-the-way-down branch

January 13, 2022 22:52