Home Original page

Revert "test: test configure ninja" by addaleax · Pull Request #30295 · nodejs/node

@addaleax 

This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: nodejs#30033

@nodejs-github-bot added the build

Issues and PRs related to build files or the CI.

label

Nov 6, 2019

richardlau

gengjiawen

addaleax added a commit that referenced this pull request

Nov 6, 2019 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: #30033

PR-URL: #30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 17, 2019 
This reverts commit 85dd9e8.

`make test` should never change the current set of `configure`
flags.

Refs: #30033

PR-URL: #30295
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>